search

danfromtitan / envars-from-node-labels

Export container environment variables from K8s node labels
Apache License 2.0
24 stars 4 forks source link

remove helm hooks #21

Closed balonik closed 1 year ago

balonik commented 1 year ago

After some trial and error I decided that having the Helm hooks there is not practical and causes issues.

The biggest issue is that resources deployed using Helm hooks are not removed when Helm release is uninstalled, so the mutatingwebhookconfiguration stays in the cluster, causes failures and needs to be manually removed.

danfromtitan commented 1 year ago

Yeah, I had a hesitation when I saw the "post-install,post-upgrade,pre-delete" hook in the previous commit :-)