danfromtitan / envars-from-node-labels

Export container environment variables from K8s node labels
Apache License 2.0
24 stars 4 forks source link

Add failurePolicy variable for MutatingWebhookConfiguration #23

Closed ivankovnatsky closed 11 months ago

ivankovnatsky commented 11 months ago

In our case we have a fallback scenario when there are no environment variables that define kafka same AZ brokers, meaning we can still connect using a single URL with the list of them.

We also host some other pods that does not depend on the webhook in the same namespace that use this configuration. So it's fine for us to have failurePolicy set to Ignore, in fact absolutely neccessary as we had minor downtimes due to webhook misbehaving.

Currently when I set webhook replicas to 0 I can't manage the pods that does not depend on it, but running in the same namespace as namespaceSelector value, Ignore policy fixes it.

danfromtitan commented 11 months ago

Looks good, please increase the chart version before I can merge ?