danfromtitan / envars-from-node-labels

Export container environment variables from K8s node labels
Apache License 2.0
24 stars 4 forks source link

Patching breaks pod rollouts #27

Closed aliaksei-imi closed 10 months ago

aliaksei-imi commented 10 months ago

After adding this addmission controller, sometimes this error breaks helm release rollouts

warning: Upgrade "app" failed: cannot patch "app" with kind Deployment: Deployment.apps "app" is invalid: spec.template.spec.containers[0].env[38].valueFrom: Invalid value: "": may not be specified when `value` is not empty

We're using flux as well, but this error is popping up randomly in some contexts, does not seem to related to flux.