Refactor app code to better follow S.O.L.I.D design principles

danfstucky commented 8 years ago

Reviewers: @sulaimonlasisi Description: This is the last of the major refactoring issues for this project.

lol client gem updated to most recent version
client is created on app startup inside config/initializers as a global variable. This is one of the few cases where a global variable is a good choice, because that variable is used in multiple locations and will never change once the app starts.
Friendships related code has undergone major refactoring
lol_connections file finally completely removed.
Models created to better encapsulate code and slim down service and presenter objects.

The code changes in this review affect almost every aspect of the app, but friendship features should especially be tested for new defects.

sulaimonlasisi commented 7 years ago

Behavior looks good. +1

danfstucky commented 7 years ago

danfstucky / LeagueSpec