danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.28k stars 368 forks source link

Needs meaningful logging when hitting MR comment character limit #1178

Open krismanceaux opened 2 years ago

krismanceaux commented 2 years ago

I'm using Danger to post certain CI-generated report findings onto a Merge Request as a comment. If the comment exceeds GitLab's 1,000,000 characters limit, the resulting log output is:

$ npx danger ci --verbose --dangerfile /app/danger/dangerfile.js
Found only messages, passing those to review.
Error:  undefined

To Reproduce:

import { message } from "danger"
const s = "some string with more than 1,000,000 characters...";
message(s);

It's understood that this is a GitLab constraint, not a Danger JS constraint, but it would be nice for the error logging to be more meaningful here.

fbartho commented 2 years ago

This issue also occurs with Github, but the comment limit is much smaller than for gitlab.