search

danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.26k stars 368 forks source link

Fix: Restore GitLabDSL.api to be GitLabAPI instance #1354

Open glensc opened 1 year ago

glensc commented 1 year ago

Revert "Ensures that the Gitlab API is exposed properly through the dts"

This reverts commit e8d20521270e283df8572c103eb330d622ab04bd.

The breakage introduced between 10.6.5 and 10.6.6 patch version update

Refs:

glensc commented 1 year ago

I think there aren't many gitlab users that has gone un-noticed that long. at least the write methods.

I do use gitlab, not so far did not need to use write functions, just used danger.gitlab json structures

glensc commented 1 year ago

@orta who can give insights and directions on how to the problem? only you?

orta commented 1 year ago

Yep, I do OSS in my increasingly little spare time and so mainly only have time for well formed non-draft PRs

glensc commented 1 year ago

hmm. I can no longer update this branch

ERROR: Permission to danger/danger-js.git denied to glensc.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.