danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.24k stars 367 forks source link

Danger is not commenting on PR #1377

Closed nirmaanlabs closed 1 year ago

nirmaanlabs commented 1 year ago

Describe the bug danger js is not commenting on pr

To Reproduce

name: Performance Tests
on:
  push:
    branches:
      - develop
      - feature/*
      - hotfix/*

jobs:
  perf-tests:
    runs-on: ubuntu-latest
    steps:
      - name: checkout-repo
        uses: actions/checkout@v3
      - name: setup-node
        uses: actions/setup-node@v3
        with:
          node-version: 18.x
          cache: npm
      - name: Install Dependencies
        run: npm ci
      - name: Performance Tests
        run: npm run test:perf

      - name: Run Danger.js
        run: DEBUG="*" npx danger ci
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

These are the logs

2023-04-09T18:07:50.840Z danger:inline_runner Started parsing Dangerfile:  dangerfile.js

2023-04-09T18:07:51.388Z danger:inline_runner Finished running dangerfile:  dangerfile.js

2023-04-09T18:07:51.388Z danger:inline_runner Scheduler waiting on: 0 tasks

2023-04-09T18:07:51.388Z danger:inline_runner Finished scheduled tasks

2023-04-09T18:08:00.287Z danger:runner Process has finished with 0, sending the results back to the host process 
2023-04-09T18:08:00.287Z danger:runner Got md 0 w 0 f 1 m 0

2023-04-09T18:08:00.287Z danger:runner Writing results into /tmp/danger-results-96c03d25.json

2023-04-09T18:08:00.290Z danger:runDangerSubprocess Got JSON URL from STDOUT, results are at: 
danger-results://tmp/danger-results-96c03d25.json
2023-04-09T18:08:00.301Z danger:runDangerSubprocess child process exited with code 0
2023-04-09T18:08:00.302Z danger:jsonToDSL Creating event DSL from JSON
2023-04-09T18:08:00.311Z danger:executor Got results back: {
  fails: [ { message: 'Changed Files in this PR: \n - ' } ],
  warnings: [],
  messages: [],
  markdowns: [],
  scheduled: []
}
2023-04-09T18:08:00.312Z danger:executor Evaluator settings {
  stdoutOnly: undefined,
  verbose: undefined,
  jsonOnly: undefined,
  dangerID: 'Danger',
  passURLForDSL: false,
  disableGitHubChecksSupport: true,
  failOnErrors: undefined,
  noPublishCheck: false,
  ignoreOutOfDiffComments: undefined,
  newComment: false,
  removePreviousComments: false
}
2023-04-09T18:08:00.313Z danger:executor Writing to STDOUT: {
  fails: [ { message: 'Changed Files in this PR: \n - ' } ],
  warnings: [],
  messages: [],
  markdowns: [],
  scheduled: []
}
Danger: ⅹ Failing the build, there is 1 fail.
## Failures
Changed Files in this PR: 
 - 

Expected behavior I was expecting to see some comments but I can't see any comments. Is it necessary to have bots ?

Screenshots If applicable, add screenshots to help explain your problem.

Your Environment

software version
danger.js 11.2.5
node 18.15.0
npm 9.5.0
Operating System ubuntu-latest

Additional context see the full ci output here

orta commented 1 year ago

You're using push actions which don't have an associated PR in the API

nirmaanlabs commented 1 year ago

works fine closing this thanks