Fix commands run without the .js extension

danger / danger-js

⚠️ Stop saying "you forgot to …" in code review

http://danger.systems/js/

MIT License

5.24k stars 367 forks source link

Fix commands run without the .js extension #1378

Closed a-riva closed 1 year ago

a-riva commented 1 year ago

With Danger 11.2.5, all our CI pipelines running Danger (with yarn run danger-ci) started to fail due to #1375 failing to replace danger-{command} to danger-runner when without the .js extension. This resulted in an endless loop of calls to danger-ci.

Making the replacement of the .js extension optional seems enough to cover our use case and @mikedidomizio 's (as the test he added in the mentioned PR still passes).

orta commented 1 year ago

Thanks!

orta commented 1 year ago

Shipped