danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.24k stars 367 forks source link

Bump CI node to 16 to fix danger_babel_test test #1393

Closed glensc closed 1 year ago

glensc commented 1 year ago

error workbox-webpack-plugin@6.6.1: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "14.21.3" error Found incompatible module.

NOTE: There's alternative solution: https://github.com/danger/danger-js/pull/1394

glensc commented 1 year ago

This is easy change to fix failing CI. Probably proper solution would be to pin some packages. Create lockfile to track them.

Or just override node version for the failing danger_babel_test job only?

glensc commented 1 year ago

trying to use older create_react_app gives this error (and there is no global package installed)

✖ yarn create-react-app danger_babel_test

You are running `create-react-app` 4.0.3, which is behind the latest release (5.0.1).

We no longer support global installation of Create React App.

Please remove any global installs with one of the following commands:
- npm uninstall -g create-react-app
- yarn global remove create-react-app

The latest instructions for creating a new app can be found here:
https://create-react-app.dev/docs/getting-started/

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
glensc commented 1 year ago

could be reproduced with npx:

✖ npx create-react-app@4 danger_babel_test
npx: installed 67 in 5.637s

You are running `create-react-app` 4.0.3, which is behind the latest release (5.0.1).

We no longer support global installation of Create React App.

Please remove any global installs with one of the following commands:
- npm uninstall -g create-react-app
- yarn global remove create-react-app

The latest instructions for creating a new app can be found here:
https://create-react-app.dev/docs/getting-started/
glensc commented 1 year ago

@fbartho @orta this is to fix CI. See also the other solution:

Merge which one suits you more.

orta commented 1 year ago

Thanks, yeah, this seems good to me 👍🏻