Closed glensc closed 1 year ago
This is easy change to fix failing CI. Probably proper solution would be to pin some packages. Create lockfile to track them.
Or just override node version for the failing danger_babel_test
job only?
trying to use older create_react_app gives this error (and there is no global package installed)
✖ yarn create-react-app danger_babel_test
You are running `create-react-app` 4.0.3, which is behind the latest release (5.0.1).
We no longer support global installation of Create React App.
Please remove any global installs with one of the following commands:
- npm uninstall -g create-react-app
- yarn global remove create-react-app
The latest instructions for creating a new app can be found here:
https://create-react-app.dev/docs/getting-started/
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
could be reproduced with npx:
✖ npx create-react-app@4 danger_babel_test
npx: installed 67 in 5.637s
You are running `create-react-app` 4.0.3, which is behind the latest release (5.0.1).
We no longer support global installation of Create React App.
Please remove any global installs with one of the following commands:
- npm uninstall -g create-react-app
- yarn global remove create-react-app
The latest instructions for creating a new app can be found here:
https://create-react-app.dev/docs/getting-started/
@fbartho @orta this is to fix CI. See also the other solution:
Merge which one suits you more.
Thanks, yeah, this seems good to me 👍🏻
NOTE: There's alternative solution: https://github.com/danger/danger-js/pull/1394