search

danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.24k stars 367 forks source link

CI: Split integration tests to own workflow #1394

Closed glensc closed 1 year ago

glensc commented 1 year ago

Split CI file to be able override it with node 16. Alternative fix to https://github.com/danger/danger-js/pull/1393

create-react-app doesn't allow running other versions than latest, and latest 5.0.1 requires node 16:

glensc commented 1 year ago

@fbartho @orta this is to fix CI. See also the other solution:

Merge which one suits you more.

orta commented 1 year ago

Opted to go with #1393 - thanks!

glensc commented 1 year ago

825d797dd02ee712d4d1c3b76e1e0eb41e5eb83d should be cherry-picked to some other branch