danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.26k stars 368 forks source link

Add dangerID to gitlab createComment api #1395

Closed glensc closed 1 year ago

glensc commented 1 year ago

Alternative fix https://github.com/danger/danger-js/pull/1381 based on review notes:

Fixes https://github.com/danger/danger-js/issues/1380#issuecomment-1519375625 Replaces https://github.com/danger/danger-js/issues/1380

orta commented 1 year ago

I see, so the issue was that the args passed into it didn't match where it is used somewhere. It doens't match how the GitHub platform works: createComment: (comment: string) => api.postPRComment(comment), but I'll assume that this is right as a few folks agree