search

danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.26k stars 368 forks source link

[BUG] substr is deprecated #1400

Closed david-allan-jones closed 3 months ago

david-allan-jones commented 1 year ago

Describe the bug There is a call to the deprecated String.prototype.substr inside of github issue template file.

/source/runner/templates/githubIssueTemplate.ts

To Reproduce I'm currently not aware of any runtime that doesn't still support this function, but it would be wise to remove it in case support gets dropped on some runtimes.

Expected behavior

This should be replaced with a different function like String.prototype.substring.

Your Environment

software version
danger.js 11
node 18
npm n/a
Operating System Ubuntu
orta commented 1 year ago

Seems reasonable, you're welcome to take a look at it

david-allan-jones commented 1 year ago

PR: https://github.com/danger/danger-js/pull/1401

igorkamyshev commented 3 months ago

Should it be closed since #1401 is merged? 🤔

fbartho commented 3 months ago

Thanks @igorkamyshev