danger / danger-js

⚠️ Stop saying "you forgot to …" in code review

http://danger.systems/js/

MIT License

5.26k stars 368 forks source link

Customise GHE actions bot user ID #1404

Closed dimitar-hristov closed 10 months ago

dimitar-hristov commented 1 year ago

Context

In GitHub actions, the user ID of the bot is hardcoded for github.com without an option to overwrite it for GitHub Enterprise. As a result when called here and here to update the PR comments, it fails to find the comments.

Changes

Adds logic to customise DANGER_GHE_ACTIONS_BOT_USER_ID.

dimitar-hristov commented 1 year ago

Hey @orta 👋 When you have a moment, could you review this PR, please?

dimitar-hristov commented 1 year ago

No objections to the purpose of this PR — just gotta make sure it doesn’t break :P — Happy to take another look once you’ve ensured it won’t!

Thanks for the quick response, @fbartho! I think all comments should now be addressed. Please have a look at the PR again when you have a moment and let me know if it is better. 🙂

orta commented 10 months ago

I think this is good to go - thanks both of you 👍🏻