Closed n-tucker closed 3 months ago
What typescript version are you running? And yes, if you can share your tsconfig that might help! Depending on versions of TypeScript, various global types are added/removed in the base config.
Blob
I think is a JS global in browsers, but it might not be a global in nodejs
, or not a global in all of TypeScript’s current build targets.
Further, the issue is coming a dependency node_modules/@gitbreaker
which is really annoying.
Thanks so much for the quick reply! 🙏
We're using version 5.2.2
of Typescript, here's our tsconfig.json
:
{
"compilerOptions": {
"target": "ES2018",
"module": "commonjs",
"lib": ["es2016", "es2017.object", "es2017.string"],
"esModuleInterop": true,
"declaration": true,
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": false,
"noUnusedParameters": false,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": false,
"inlineSourceMap": true,
"inlineSources": true,
"experimentalDecorators": true,
"strictPropertyInitialization": false,
"resolveJsonModule": true
},
"exclude": ["parameter-store", "cdk.out"]
}
LMK if you need any more info! Thanks again!
I had this error the other day. I am pretty sure I solved it by installing @types/node
. I think I might have needed to install it globally at that, which was weird.
@n-tucker definitely check out @types/node
— this really sounds familiar to something I resolved in one of my projects a couple years ago! I think it was something like adding @types/node
or a different polyfill patch.
Describe the bug We recently have a version bump for
danger
suggested to us via renovate. Our GHA tests fail on the build step, which seems to suggest that something has changed within thegitbeaker
version bump specified in the changelogTo Reproduce Steps to reproduce the behavior:
11.2.8
11.3.0
tsc
Expected behavior No errors should occur. I can confirm this by switching to a branch without the version bump, running![image](https://github.com/danger/danger-js/assets/8991772/9c7c992b-7099-4fb0-9e27-5240f4973efa)
tsc
works without issuesConfig shouldn't need to be changed for a non-major version release
Screenshots
Build error in GHA![image](https://github.com/danger/danger-js/assets/8991772/fc596018-a152-4362-9a86-48c0d368b10e)
Build error on local Mac![image](https://github.com/danger/danger-js/assets/8991772/bafad41a-2084-4345-b6f6-47a138b0aa41)
Confirmation that the errors in question are coming from danger![image](https://github.com/danger/danger-js/assets/8991772/15fc3f55-5775-4ff2-96e1-228afcc3f120)
Your Environment
Additional context As shown in the second screenshot, I'm also able to reproduce this locally on my Mac (M1 Pro, Ventura 13.6).
If there's some sort of workaround in
tsconfig.json
I can implement I'm also happy to hear about that too! TIA for any assistance!