Clear missing DSL timeout to allow danger runner to exit when done

danger / danger-js

⚠️ Stop saying "you forgot to …" in code review

http://danger.systems/js/

MIT License

5.26k stars 368 forks source link

Clear missing DSL timeout to allow danger runner to exit when done #1411

Closed normano64 closed 10 months ago

normano64 commented 11 months ago

I noticed that the danger step in CI was always taking more than 10 seconds, the root cause was that nodeCleanup was waiting for the missing DSL timeout before continuing even when the DSL was found

orta commented 10 months ago

This makes sense to me 👍🏻 - great find