danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.22k stars 363 forks source link

GHCR publishing is broken #1414

Closed vaind closed 7 months ago

vaind commented 8 months ago

There hasn't been an image pushed to ghcr.io since 11.2.7, see https://github.com/danger/danger-js/actions/workflows/publish_package.yml

The build log indicates a permission issue: buildx failed with: ERROR: denied: permission_denied: write_package

From what I've gathered in https://github.com/orgs/community/discussions/32184 and https://stackoverflow.com/a/72585915/2386130, you may need to set permissions on the package itself.

orta commented 8 months ago

good spot, I don't really use that feature - I've set it on based on the settings and we'll see on the next deploy 👍🏻

orta commented 7 months ago

Looks fixed to me, thanks - https://github.com/danger/danger-js/actions/runs/7131622609/job/19420525245

vaind commented 7 months ago

yes, works fine now, thanks