search

danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.22k stars 363 forks source link

[BUG] Can you push updated images to dockerhub? #1422

Closed jaymzh closed 5 months ago

jaymzh commented 6 months ago

Describe the bug The dangersystems org on dockerhub has a danger-js image from 5 years ago.

The default mechanism for including danger-js to a GH runner causes the GH runner to build the entire image, which adds several minutes to CI. I'd like to be able instead to just use an existing image. Any chance of getting that updated? Thanks!

orta commented 6 months ago

We post to GHE, which I think should be what you need here: https://github.com/danger/danger-js/pkgs/container/danger-js

jaymzh commented 6 months ago

Oh brilliant, thanks!

Is that linked from anywhere? It's not under GH releases and I don't see it linked from the README. Wondering if I just missed it. If not perhaps add that to the README?

orta commented 6 months ago

It doesn't look like it! Release support came from a contributor, and it's not something I really understand or use

After I read your issue I enabled in GitHub environments which at least shows it in the packages section down here: image

jaymzh commented 5 months ago

Looks good, thanks. I can confirm I was able to use that image successfully.