danger / danger-js

⚠️ Stop saying "you forgot to …" in code review
http://danger.systems/js/
MIT License
5.22k stars 363 forks source link

Use node 18 targets for yarn pkg #1449

Closed heltoft closed 2 months ago

heltoft commented 2 months ago

With the move to node 18 in v12.0.0 the targets for the yarn pkg command was not updated as expected.

These commands are used by the homebrew-tap and fixes the issue of having an outdated node version as part of the compiled binaries when installing with brew as outlined in: https://github.com/danger/danger-js/issues/1448

This should suffice to fix the underlying issue, but I think it could be worth to look into the option of not bundling node in as part of the binary and instead use what is already available on the system it is running on.

orta commented 2 months ago

Cool, makes sense to me 👍🏻