don't return nil values as reviewers

danger / danger-mention

Danger plugin to automatically mention potential reviewers on pull requests

MIT License

30 stars 12 forks source link

don't return nil values as reviewers #13

Closed mikz closed 7 years ago

mikz commented 7 years ago

to prevent following exception:

    from lib/danger_plugin.rb:53:in `block in run'
    from lib/danger_plugin.rb:53:in `map'
    from lib/danger_plugin.rb:53:in `run'

On some new repos this plugin would fail because it would not be able to detect reviewers and return nil values that can't be concatenated with strings to make the mention.

orta commented 7 years ago

Oops, I missed this PR - thanks!

mikz commented 7 years ago

@orta could you do a new release? I'm still hitting this in some cases.

orta commented 7 years ago

Shipped 👍 screen shot 2017-07-04 at 13 39 14

mikz commented 7 years ago

Thank you!

1. 2017 v 19:39, Orta notifications@github.com:

Shipped 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.