search

danger / danger-plugin-template

An opinionated template for creating a Danger plugin
Other
20 stars 10 forks source link

Simplify spec_helper regarding danger_ui? #8

Closed dblock closed 8 years ago

dblock commented 8 years ago

What's the reason for all of https://github.com/danger/danger-plugin-template/blob/master/spec/spec_helper.rb#L29?

Can I just do the following and should it be changed here?

def testing_ui
  Cork::Board.new(silent: true)
end
orta commented 8 years ago

You can, but you don't get the de-colourizing, and ensure that you get consistent line breaks among different test runners

orta commented 8 years ago

so you have less determinate tests, and harder to test strings