search

danger / danger.systems

Old website for Danger.Systems -> New website =
https://gitlab.com/danger-systems/danger.systems
MIT License
10 stars 15 forks source link

GitHub account: write access, right? #56

Closed epologee closed 8 years ago

epologee commented 8 years ago

https://github.com/danger/danger.systems/blob/master/static/source/guides/getting_started.html.slim#L73 states you should add the bot to the (closed source) repo. Doing that GitHub will present options for Admin, Write or Read. I'm assuming the bot needs write-access, but it might prevent some confusion if this were part of the getting started docs.

Happy to submit a pull request if this is correct and you agree. Cheers!

orta commented 8 years ago

I think it only needs read - though I have no private repos to test it on :D

orta commented 8 years ago

The Danger bot only needs to comment on PRs, I think that would be allowable via read

epologee commented 8 years ago

When I change the access to 'Read', Danger fails quite neatly with:

Danger has failed this build. Found 1 error and I don't have write access to the PR set a PR status.

So I guess write access is required!

orta commented 8 years ago

Yep - makes sense then 👍

epologee commented 8 years ago

Alright, I've created PR #60 for it, let's close this one.