danger / danger.systems

Old website for Danger.Systems -> New website =
https://gitlab.com/danger-systems/danger.systems
MIT License
10 stars 15 forks source link

Adding danger-simplecov_json to plugins.json #92

Closed marcelofabri closed 8 years ago

marcelofabri commented 8 years ago

My first open source plugin 😅

DangerCI commented 8 years ago

Failed to parse danger-simplecov_json

simplecov

Report your Ruby app test suite code coverage.

You can use simplecov to gather code coverage data and a json formatter so this plugin can parse it.

Report code coverage
simplecov.report_coverage('coverage/coverage.json')

Methods

report - Parse a JSON code coverage file and report that information as a message in Danger.


Generated by :no_entry_sign: danger

marcelofabri commented 8 years ago

"Failed to parse" doesn't look good 😬

orta commented 8 years ago

Alright, this looks good - the Dangerfile's wording must be wrong, but sure, this'll need a rebase, as you're there, can you turn it for one LOC to many? We're going to get a lot of "can you rebases" otherwise 💃

marcelofabri commented 8 years ago

Rebased 💯

orta commented 8 years ago

Rock, site building is down AMT but should be able to get it back up this eve