danger / generator-danger-plugin

Yeoman generator to generate a Danger plugin
MIT License
8 stars 3 forks source link

feat($dev): Initial work on support for a TypeScript project #16

Closed orta closed 7 years ago

orta commented 7 years ago

OK, so this is the required changes to start making typescript based plugins from the template

orta commented 7 years ago

I'm gonna look at the actual typescript setup now

orta commented 7 years ago

Great job on the tests BTW, made it so easy

orta commented 7 years ago

I ended up running prettier on the main index file, the diff is gonna get messy from here on in ;)

orta commented 7 years ago

OK, TypeScript support is now well good

screen shot 2017-06-10 at 13 35 16

macklinu commented 7 years ago

@orta you rock! I'll have a chance to take a deeper look at this later this weekend or early in the workweek. Thanks so much for getting this going - writing plugins in TypeScript is an awesome experience. ❤️

macklinu commented 7 years ago

Ooo, we can also update this project's README.md to say it supports TypeScript too! ❤️

image

orta commented 7 years ago

Yah, I got ~10m, I might be able to get all this done

orta commented 7 years ago

OK green now