danger / peril

☢️ Serious and immediate danger.
https://danger.systems
MIT License
461 stars 58 forks source link

Fixes problem where JSON url was overwriting Slack webhook url #452

Closed ashfurrow closed 5 years ago

ashfurrow commented 5 years ago

Whenever we updated the JSON settings URL, we noticed that the Slack Incoming Webhook URL was getting overwritten with the same value (ie: both values were being saved as the JSON URL). This should fix that.

Didn't see any tests to update, but let us know 👍

Looks like Prettier updated the file with some unrelated style changes.

orta commented 5 years ago

Yep, looks legit to me 👍