danger / python

⚠️ Stop saying "you forgot to …" in code review
https://danger.systems/python
MIT License
106 stars 47 forks source link

Python runner POC #1

Closed turekj closed 4 years ago

turekj commented 4 years ago

Hey @orta!

I have tried to build upon the initial implementation to create a project similar to the Danger Swift. Currently, the runner:

Please, let me know what is your general feedback on this and what would it take to merge the PR into the master of the repository.

To test the app, you can emulate the steps provided in the README:

# install danger
npm install -g danger
# install poetry
pip install poetry
# install project dependencies
poetry install
# activate virtual environment
poetry shell
# run danger-python
danger-python pr https://github.com/microsoft/TypeScript/pull/34806

I've only tested the setup with Python 3.7 running on MacOS 10.15.2.

orta commented 4 years ago

If you're happy, I'll merge and you'll get an invite to be a member of the org. WRT this repo, I trust you to know more about the python ecosystem and the way in which Python danger should feel. I will assist however I can.

I'll be around to help answer questions, and provide someone for a reasonable code review and you have a slack invite so that you can directly ping me synchronously if needed.

turekj commented 4 years ago

I've updated the authors and I think we're ready to merge this part 👍 I'm happy to continue the work on the DSL and the plugins later. Thank you for the review! 🙇

orta commented 4 years ago

👍