Closed turekj closed 4 years ago
If you're happy, I'll merge and you'll get an invite to be a member of the org. WRT this repo, I trust you to know more about the python ecosystem and the way in which Python danger should feel. I will assist however I can.
I'll be around to help answer questions, and provide someone for a reasonable code review and you have a slack invite so that you can directly ping me synchronously if needed.
I've updated the authors and I think we're ready to merge this part 👍 I'm happy to continue the work on the DSL and the plugins later. Thank you for the review! 🙇
👍
Hey @orta!
I have tried to build upon the initial implementation to create a project similar to the Danger Swift. Currently, the runner:
ci
,local
andpr
commands todanger-js
passing itself as a runner,run
command that executes contents ofdangerfile.py
and reports the result back todanger-js
process,warn
,fail
,message
,markdown
).Please, let me know what is your general feedback on this and what would it take to merge the PR into the master of the repository.
To test the app, you can emulate the steps provided in the README:
I've only tested the setup with Python 3.7 running on MacOS 10.15.2.