danger / swift

⚠️ Stop saying "you forgot to …" in code review
https://danger.systems/swift/
MIT License
1.04k stars 136 forks source link

Danger doesn't work with Mint, removing it #503

Closed f-meloni closed 2 years ago

colejd commented 1 year ago

Hello! @f-meloni, when you get a chance, could you please explain why you removed this? Is there a technical limitation with Mint that prevents Danger from working with it? I know SPM presents some limitations sometimes, and all you can do is hope Apple fixes it someday - otherwise, I'd like to get a PR going for you to fix the issue if it's possible.

f-meloni commented 1 year ago

Hi @colejd, sure! Danger is made of two parts, one is a binary and one is a swift library that is linked when the Dangerfile is compiled in order to make the compiler resolve the Danger specific symbols (warn, message, Danger(), etc.). Mint only installs the bin part, so when you go to compile the Dangerfile, that compilation fails. There are probably some workarounds you can adopt to get the library from SPM, but they require a Package.swift, and if you have a Package.swift you can just use swift run danger-swift