danger / swift

⚠️ Stop saying "you forgot to …" in code review
https://danger.systems/swift/
MIT License
1.04k stars 135 forks source link

[discussion] Drop Swift 5.3 support #523

Closed 417-72KI closed 2 years ago

417-72KI commented 2 years ago

Suggestion

Motivation

There is an issue and workaround for building Danger-Swift in Swift 5.3 Docker image (https://github.com/danger/swift/issues/375, https://github.com/danger/swift/pull/426).

Fortunately, I tried to run swift build --disable-sandbox -c release in Swift 5.4 image and succeeded! I think that supporting Swift 5.3 is no longer necessary.

Additionally, dropping Swift 5.4 is more happier for CI because

f-meloni commented 2 years ago

Thank you for writing this issue :) I'm totally OK with dropping Swift 5.3, and wait a little bit before dropping Swift 5.4, Ideally I would wait for the new Xcode major to come out and then drop that as well :)

417-72KI commented 2 years ago

Thank you for reactions! I will make a PR to prepare dropping 5.3 only and open a new issue for 5.4 🚀