danger / swift

⚠️ Stop saying "you forgot to …" in code review
https://danger.systems/swift/
MIT License
1.05k stars 141 forks source link

feat: Update SwiftLint used by danger-swift-with-swiftlint to 0.49.1 #538

Closed Kiran-B closed 2 years ago

Kiran-B commented 2 years ago

Update SwiftLint from v0.46.1 -> 0.49.1 in the Dockerfile.

Details about whats new in SwiftLint is available here: https://github.com/realm/SwiftLint/releases

Kiran-B commented 2 years ago

I wasn't sure whether the CHANGELOG.md needs to be updated. Do let me know if that's required. Thanks.

f-meloni commented 2 years ago

It would be definitely nice! Thank you :)

Kiran-B commented 2 years ago

Sure. Updated.

f-meloni commented 1 year ago

Hey @Kiran-B sorry, I had to temporarily revert this, because at the moment is not working, and so the build for the release failed :(

https://github.com/danger/swift/actions/runs/3249467853/jobs/5331906227#step:8:128

Kiran-B commented 1 year ago

Sorry, my bad. Missed updating Docker Container. Need to replace

FROM swift:5.5.3-focal

with

FROM swift:5.6.3-focal

or (to future proof)

FROM swift:5.7.0-focal