search

danger / swift

⚠️ Stop saying "you forgot to …" in code review
https://danger.systems/swift/
MIT License
1.04k stars 135 forks source link

Update --cwd explanation #552

Closed dlewandaDK closed 6 months ago

dlewandaDK commented 1 year ago

Make it clear which directory the command must be run from and what directory to pass to --cwd

jeffctown commented 6 months ago

@dlewandaDK - TY for putting this up!

@f-meloni - Is there a reason this isn't merged? I just spent about 3 hours trying to get --cwd working and I was very lucky to stumble upon this PR. Please merge this so nobody else is confused how to use the cwd param. 🙏

f-meloni commented 6 months ago

I have looked the PR, it seems good to be honest, don't remember why I didn't merge it at the time, but I will now. Hope this will help future danger swift users