danger / swift

⚠️ Stop saying "you forgot to …" in code review
https://danger.systems/swift/
MIT License
1.04k stars 135 forks source link

SwiftLint ignores "swiftlint:disable" comments on Linux with Swift 5.7 environment #556

Open pepix opened 1 year ago

pepix commented 1 year ago

Issue

SwiftLint doesn't ignore rules even though there is swiftlint:disable comments in our code. This issue is only happened on Linux with greater than or equal to Swift 5.7 environment.

image

Root cause

it seems SwiftLint itself had a problem and they've already fixed in 0.50.0 release. However danger-swift is using SwiftLint 0.48.0 now.

Comment

Though bump SwiftLint might fix this issue, according to their release note, SwiftLint requires Swift 5.7 after that. @f-meloni