danger / swift

⚠️ Stop saying "you forgot to …" in code review
https://danger.systems/swift/
MIT License
1.04k stars 135 forks source link

SwiftLint update strategy #562

Open icecoffin opened 1 year ago

icecoffin commented 1 year ago

Currently the latest danger-swift-with-swiftlint Docker image is using SwiftLint 0.48.0 which was released in July 2022, so it's a couple of versions behind. This introduces some issues:

As far as I understand, bumping the SwiftLint version would require a new Danger Swift release. Would this alone be a good enough reason for a new release? If so, are we encouraged to do it?

hlung commented 5 months ago

I'd love to see this fixed too. Maybe some workaround to allow pointing to a custom swiftlint binary, so that we don't have to require a new Danger Swift release. Or some other way.