search

danger / swift

⚠️ Stop saying "you forgot to …" in code review
https://danger.systems/swift/
MIT License
1.04k stars 135 forks source link

Edit Dangerfile as a Swift Package on `danger-swift edit` instead of `xcodeproj` #566

Closed 417-72KI closed 1 year ago

417-72KI commented 1 year ago

Resolves: #563

417-72KI commented 1 year ago

NOTE: CI on Swift 5.7 fails due to SwiftLint issue (https://github.com/realm/SwiftLint/issues/4031).

I tried to bump SwiftLint to resolved version, error occured on resolving dependencies.

Failed to resolve dependencies Dependencies could not be resolved because root depends on 'swiftlint' 0.51.0..<1.0.0 and root depends on 'rocket' 1.2.1..<2.0.0. 'rocket' is incompatible with 'swiftlint' because 'swiftlint' 0.51.0 depends on 'yams' 5.0.5..<6.0.0 and no versions of 'swiftlint' match the requirement 0.51.1..<1.0.0. 'rocket' >= 1.2.1 practically depends on 'yams' 4.0.0..<5.0.0 because no versions of 'rocket' match the requirement 1.2.2..<2.0.0 and 'rocket' 1.2.1 depends on 'yams' 4.0.0..<5.0.0.

417-72KI commented 1 year ago

@f-meloni @orta Could you please review https://github.com/shibapm/Rocket/pull/50 and release it if you can? It is a bottleneck for this.