danger / swift

⚠️ Stop saying "you forgot to …" in code review
https://danger.systems/swift/
MIT License
1.04k stars 135 forks source link

Danger Swift not working with Github Merge Queue #598

Open spqw opened 7 months ago

spqw commented 7 months ago
f-meloni commented 7 months ago

I have not used merge queues, so I'm not sure how much I can help but I will try 😁 Which CI platform are you using to run danger? GitHub actions?

spqw commented 7 months ago
f-meloni commented 7 months ago

Danger, in order to work, needs the PR data, to get that it takes from the CI platform the PR ID and repo slug. In team city this means that the env variable PULL_REQUEST_URL needs to be present and correct https://github.com/danger/danger-js/blob/main/source/ci_source/providers/TeamCity.ts Is that variable present?

spqw commented 7 months ago

Examples of DSL elements we are using and that we want to be able to run on merge queue checks

Examples of DSL elements we would like to use on pull requests checks, and skip on merge queue checks, i.e. check the current branch starts with gh-readonly-queue