Please include a PR URL

danger / swift

⚠️ Stop saying "you forgot to …" in code review

https://danger.systems/swift/

MIT License

1.04k stars 135 forks source link

Please include a PR URL #611

Closed DntPullALockett closed 2 weeks ago

DntPullALockett commented 3 weeks ago

I have Danger Swift implemented in a production project and also a test project. Implementation is exactly the same but for one it keeps failing that I need to include a PR URL even though one is given.

Danger Swift Version: 3.18.1

This is a private repo.

Not working: swift run danger-swift pr https://github.com/rcg-digital-mobile/danger-swift-test/pull/1 Building for debugging... [1/1] Write swift-version--58304C5D6DBC2206.txt Build complete! (0.60s) Please include a PR URL to run against

orta commented 3 weeks ago

you want danger-swift ci - the pr command is for testing against a specific pr

DntPullALockett commented 3 weeks ago

@orta Yes I am testing this locally, not on a CI system

Why would pr work for one and not another when a url is being passed.