search

dangilman / pyHalo

A python toolkit for rendering populations of dark matter halos for gravitational lensing simulations
MIT License
25 stars 13 forks source link

PBH_dev #13

Closed vdike closed 3 years ago

vdike commented 3 years ago

dummy pull request again

dangilman commented 3 years ago

Hi Veronica, it looks like your pull request on the PBH_dev branch is working correctly, now just have to add the code you wrote to the pull request and get rid of the dummy text file. Once you add your code and submit the new pull request, I'll merge it into my branch of PBH_dev and then we can work on it together. By what day do you think you have this done?

vdike commented 3 years ago

Hi Veronica, it looks like your pull request on the PBH_dev branch is working correctly, now just have to add the code you wrote to the pull request and get rid of the dummy text file. Once you add your code and submit the new pull request, I'll merge it into my branch of PBH_dev and then we can work on it together. By what day do you think you have this done?

I think both branches are identical at this point because I originally pushed to the upstream.

dangilman commented 3 years ago

Hi Veronica, it looks like your pull request on the PBH_dev branch is working correctly, now just have to add the code you wrote to the pull request and get rid of the dummy text file. Once you add your code and submit the new pull request, I'll merge it into my branch of PBH_dev and then we can work on it together. By what day do you think you have this done?

I think both branches are identical at this point because I originally pushed to the upstream.

your PBH_dev branch doesn't include any of the code you wrote, it is the same as the master branch. I think you should incorporate the new stuff you've done into your branch of PBH_dev into the pull request

vdike commented 3 years ago

Hi Veronica, it looks like your pull request on the PBH_dev branch is working correctly, now just have to add the code you wrote to the pull request and get rid of the dummy text file. Once you add your code and submit the new pull request, I'll merge it into my branch of PBH_dev and then we can work on it together. By what day do you think you have this done?

I think both branches are identical at this point because I originally pushed to the upstream.

your PBH_dev branch doesn't include any of the code you wrote, it is the same as the master branch. I think you should incorporate the new stuff you've done into your branch of PBH_dev into the pull request

Okay, I'll have it fixed this afternoon