dangilman / pyHalo

A python toolkit for rendering populations of dark matter halos for gravitational lensing simulations
MIT License
25 stars 13 forks source link

Add fluctuations #20

Closed AlexLaroche7 closed 2 years ago

AlexLaroche7 commented 2 years ago
dangilman commented 2 years ago

Yes please

On Jan 19, 2022, at 2:29 PM, AlexLaroche7 @.***> wrote:

@AlexLaroche7 commented on this pull request.

In pyHalo/realization_extensions.py https://github.com/dangilman/pyHalo/pull/20#discussion_r788030024:

  • args_fluc=[{'amp': amps[i], 'sigma': sigs[i], 'center_x': xs[i], 'center_y': ys[i]} for i in range(len(amps))]
  • fluctuations = [Gaussian(5*sigs[i], xs[i], ys[i], None, None, realization._zlens, None, realization.lens_cosmo,args_fluc[i],np.random.rand()) for i in range(len(amps))] That was a bug, it should have been:

masses=[GaussianKappa().mass_3d_lens(5*arg_fluc['sigma'],arg_fluc['amp'],arg_fluc['sigma']) for arg_fluc in args_fluc]

and then I use those masses instead of 5*sigs[i]. Do you want me to implement this mass definition in the Gaussian class?

— Reply to this email directly, view it on GitHub https://github.com/dangilman/pyHalo/pull/20#discussion_r788030024, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXTNDWPK4IOFDSAXXCHI4DUW37HVANCNFSM5MKOYZVA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.

AlexLaroche7 commented 2 years ago

Forgot to change the corresponding tests after modifying the free parameters in the fluctuations realization extension, will do that soon