search

dangilman / pyHalo

A python toolkit for rendering populations of dark matter halos for gravitational lensing simulations
MIT License
25 stars 13 forks source link

2Point_Correlation #42

Closed BirendraDh closed 1 year ago

dangilman commented 1 year ago

Hi @BirendraDh, thanks for setting this up! The code itself looks good to me, I just have a couple formatting/organization requests. 1) can you put a method in RealizationExtensions to actually compute the 2 point function for a given realization? For this, you can use the multiplane_convergence function in the utilities.py file to get the convergence map for a given realization, and then make calls to the other functions you wrote to compute the correlation function. 2) make sure everything is documented 3) please write test functions for each new function

BirendraDh commented 1 year ago

@dangilman I did the modifications. A test file for the fitting function was also added. BD

BirendraDh commented 1 year ago

Done!