Closed cgannonucm closed 1 year ago
Hi @cgannonucm, looks good to me. For some reason your pull request doesn't trigger tests and the coveralls run, I'm not sure why. In the meantime, it looks like there are some merge conflicts with the main branch that need to be resolved. In particular, the preset model functions are now all distributed in their files in the PresetModels class folder -- you can put this one in the external.py file. Maybe if you fix the merge conflicts it will trigger the tests and coverage runs.....
Hi @dangilman This branch and the main branch should be merged now, and all conflicts resolved.
@cgannonucm thanks! It looks like there is a problem with one of the test functions for a different method that is causing the tests to fail, would you mind fixing it so that the coverage and tests run? You just have to change the function names in the import statement of test_realization_extensions.py from _xi_l, _xi_l_to_Pk_l to "xi_l" and "xi_l_to_Pk_l". Then it should work
@dangilman Done. The tests should run now.
Implements the ability to create a realization from a Galacticus output file.