dangilman / pyHalo

A python toolkit for rendering populations of dark matter halos for gravitational lensing simulations
MIT License
25 stars 13 forks source link

Import galacticus subhalos example #46

Closed cgannonucm closed 1 year ago

cgannonucm commented 1 year ago

Implements the following changes

dangilman commented 1 year ago

@cgannonucm could you please add test functions for the classes and methods you created? You can have a look at the test suites in pyHalo located in pyhalo/tests

dangilman commented 1 year ago

@cgannonucm I think the tests are failing because the syntax you used to merge dictionaries isn't supported in python 3.8

dangilman commented 1 year ago

@cgannonucm ok everything looks great! Do you need to make any changes to the example notebook so that it is compatible with the latest changes? If not, then I'll go ahead and merge this

cgannonucm commented 1 year ago

The notebooks should be good to go! I would like to push one more commit, before we merge. I am going to add the parameter file used to generate the (galacticus) output file.

cgannonucm commented 1 year ago

@dangilman Everything should be good to go after tests finish up.