search

dangilman / pyHalo

A python toolkit for rendering populations of dark matter halos for gravitational lensing simulations
MIT License
25 stars 13 forks source link

multiplane_convergence in utilities #47

Closed BirendraDh closed 1 year ago

BirendraDh commented 1 year ago

@dangilman A kappa map generated by the multiplane_convergence imported from pyHalo.utilities is twice as big as the lensed picture. This choice, in my opinion, lengthens the computation of correlation by at least four times. To fix this, I modified multiplane_convergence function in pyHalo.utilities.

BirendraDh commented 1 year ago

I accidentally uploaded and deleted a zip file, so disregard the first two commits.

dangilman commented 1 year ago

@dangilman A kappa map generated by the multiplane_convergence imported from pyHalo.utilities is twice as big as the lensed picture. This choice, in my opinion, lengthens the computation of correlation by at least four times. To fix this, I modified multiplane_convergence function in pyHalo.utilities.

hi @BirendraDh , if that is the case, then you have the option of changing either the size of the convergence map or the size of the lensed image, and that functionality I thiink is already implemented. I don't think this warrants a pull request to change the multiplane_convergence function, which is doing what it's supposed to do