Address uldm feedback - Githubissues

dangilman / pyHalo

A python toolkit for rendering populations of dark matter halos for gravitational lensing simulations

MIT License

25 stars 13 forks source link

Address uldm feedback #7

Closed AlexLaroche7 closed 3 years ago

AlexLaroche7 commented 3 years ago

Issues addressed:

Add documentation to ULDM class functions
Change sigma crit to correct formula
Fix m22 bug in core radius equation and adjust units to coincide with Schive et al. 2014
Correct equation references
Fix xc = rc / a in central density equation
Change ULDM particle mass to log units
Create individual functions for core radius and central density, now mirror Schive equations

Issues remaining:

Not sure where central density conversion to kappa_0 formula comes from (used in lenstronomy code)

dangilman commented 3 years ago

hi, looks good to me. I checked and kappa_0 result comes from directly integrating the 3D density profile to get the projected mass, and evaluating at r=0.