Closed seanchapman closed 1 year ago
Hey! Thanks for the contribution! I'm really glad people want to improve the project. I have not looked yet into the code (will do it in the next week). In the meantime could I ask you to change the target branch to the development one? :) Lately I have not been able to work on the project but I have many improvements in mind, hopefully I'll be able to add some soon enough.
Just changed that now :) Looking forward to seeing what improvements you had in mind! The persistence of it remembering which card you were last using is really nice for the longer games.
Everything looks good! Awesome job!
Hey, thanks for the great software! It inspired me to get creative and contribute, and I think this is a nice improvement! Hopefully the community thinks so too. This is also my first public pull request on GitHub, so that's pretty exciting for me.
Here's the changes:
Sidenote: The return value for update_prev_loaded_memcard_index isn't used but included for debugging purposes. I think it's better to retain the rest of the functionality in the event of an error, rather than stop the execution flow there. In theory this will never happen without other operations erroring anyway though.
Please let me know what you think, or if there's anything that you think should be improved. I tried to keep the style inline with the rest of the project.
Cheers :)