dangiu / PicoMemcard

Emulating PSX Memory Card (or controller) using a Raspberry Pi Pico
GNU General Public License v3.0
528 stars 38 forks source link

Memory Card switching order #56

Open realJoshByrnes opened 1 year ago

realJoshByrnes commented 1 year ago

As per https://github.com/dangiu/PicoMemcard/issues/40#issuecomment-1482001010

it will load card 0.MCR as it should, first switch it will load 1.MCR, on the 2nd switch it will load 10.MCR, on the 3rd switch it will load 11.MCR, on the 4th switch it will load 12.MCR, on the 5th switch it will load 13.MCR, on the 6th switch it will load 14.MCR, on the 7th switch it will load 15.MCR, on the 8th switch it will load 2.MCR, on the 9th switch it will load 3.MCR, on the 10th switch it will load 4.MCR, on the 11th switch it will load 5.MCR. on the 12th switch it will load 6.MCR, on the 13th switch it will load 7.MCR, on the 14th switch it will load 8.MCR, on the 15th switch it will load 9.MCR.

PMC+ is sorting images alphabetically as per https://github.com/dangiu/PicoMemcard/blob/pmc%2B/release/src/memcard_manager.c#L93 which is problematic for numbering (1, 10, 11, .. 19, 2, 20, 21...)

dangiu commented 1 year ago

🤦‍♂️🤦‍♂️🤦‍♂️ nice catch!

wired-filipino-owl commented 1 year ago

Has this been resolved with the new release 1.03, or are we waiting for testing?

dangiu commented 1 year ago

Still needs to be fixed, I forgot about this

whitezombie2000 commented 1 year ago

I attempted to test this issue last night before dangiu posted that it was not fixed yet. I have two clone Pico cards from China. I flashed v1.03 and the card would no longer function when inserted into my PS1. It will not read and the LED light will not come on. It works when inserted into the PC, I can read the files, and put it into flash mode. I flashed v1.02 and it worked just fine in the PS1. I also flashed realJoshByrnes forked v1.0.22 and it worked fine. I noticed the file size increased a lot with v1.03, it's 646 KB, v1.02 is 166 KB, and the forked version is 180 KB. I don't know if something got messed up with v1.03 but thought I would mention the issue I was having.

wired-filipino-owl commented 1 year ago

@whitezombie2000 this looks worthy of opening a new issue

When I get time, I'll also try with my clone card.

whitezombie2000 commented 1 year ago

@wired-filipino-owl Sounds good. I have two of these black ones.

PSX_Mem_Card

dangiu commented 1 year ago

@whitezombie2000 you are right. Wierd, i tested it on my pico and it worked... Right now I'm on vacation but once I get back I will try to figure out what is going on... With this release there have been quite a few PR merged and I may have missed something that resulted in the huge increase in code size. My guess is that it may be something related to PR #53 since it applies only to Pico and not to RP2040-Zero

whitezombie2000 commented 9 months ago

@wired-filipino-owl Did you ever test your card to see if you could replicate the issue?

@dangiu Did you ever get a chance to look at the code and figure out why the code size increased so much?

Thanks everyone!

realJoshByrnes commented 9 months ago

@dangiu Did you ever get a chance to look at the code and figure out why the code size increased so much? Thanks everyone!

I believe the code increase in size may have been #53 (this was expected) as some of the wireless stuff has to be included for the Pico_W support (even though we're not using wireless, the LED etc is managed by the wireless chip).

whitezombie2000 commented 9 months ago

@realJoshByrnes Did you have a clone to test?

wired-filipino-owl commented 9 months ago

@wired-filipino-owl Did you ever test your card to see if you could replicate the issue?

@dangiu Did you ever get a chance to look at the code and figure out why the code size increased so much?

Thanks everyone!

@whitezombie2000 I'm away on summer vacation right now. Thanks for keeping the issue active! If this is still ongoing when I return, I will test the latest build with my clone Pico memory card.

dangiu commented 9 months ago

@whitezombie2000 no I did't look into it yet but I agree with @realJoshByrnes . I'm also way on vacation and will be back working on the project at the end of september :)

wired-filipino-owl commented 9 months ago

Tried 1.0.3 out on the Aliexpress card. Used Pico firmware, since that worked previously. I'm guessing the Zero firmware has a different pinout.

Results: Card is unresponsive with SD card inserted. Status LED does not light up. With SD card removed, status LED will come on after inserting card. LED is pink, not red. Opening up the case reveals that the status LED is an RGB LED, complete with three resistors running to it??? I tried the Zero firmware (1.0.2) and the card was unresponsive.

Went back to 1.0.2 Pico firmware and the card worked again.

I think I'll stay on 1.0.2 for now.

dangiu commented 8 months ago

Thanks for the testing, maybe I'll write a comment about this on the main page. I'm not involved in any way with those chinese products so I don't really know how they were engineered and which pinout they use