dangiu / PicoMemcard

Emulating PSX Memory Card (or controller) using a Raspberry Pi Pico
GNU General Public License v3.0
528 stars 38 forks source link

Misc refactoring and bugfix #58

Closed dangiu closed 1 year ago

dangiu commented 1 year ago

This PR includes a bunch of fix and general improvement for the code.

The biggest things are:

I haven't been able to test these changes because part of my development setup broke, if anybody is willing to test and confirm that everything works it would be awesome. Otherwise I will do it as soon as I get new parts. I will not be able to test the stuff related to PSIO since I don't own one.

dangiu commented 1 year ago

There are still a few things that would be nice to fix before the merge. In particular now I needed to define the pinout in the PIO file, I haven't found a way to include external header so that they are usable by the PIO file, haven't looked to hard though. I think there may be a way otherwise it's probably possible to do via manual modification of the files processed by pioasm.

realJoshByrnes commented 1 year ago

I will not be able to test the stuff related to PSIO since I don't own one.

I haven't checked your changes, but loading a game via the latest UniRom should have the desired effect (it sends the game to the PicoMemCard)