search

dangmoody / HLML

Auto-generated maths library for C and C++ based on HLSL/Cg
24 stars 1 forks source link

Bug fixes for Quaternions #62

Closed Flave229 closed 2 years ago

dangmoody commented 2 years ago

Your changes to the build scripts look unnecessary. It just looks make you've moved the file extension handling to some other part of the script? I don't see the point of this.

Flave229 commented 2 years ago

Your changes to the build scripts look unnecessary. It just looks make you've moved the file extension handling to some other part of the script? I don't see the point of this.

Regarding the .bat scripts, it was passing the .exe in as the output_filename, which results in doubling up on the extensions. For example, the pdb files would appear as name.exe.pdb, which seems non-standard to me. These changes fix that.

The changes to premake5.lua are necessary as the old values are just incorrect and VS won't compile without them. See the updated "source" arguments being passed to build_msvc.bat, for example. It was passing in files that no longer exist (renamed).