search

dangngocduc / comment_tree

Render comment tree like facebook comment - reply
MIT License
55 stars 39 forks source link

Still draws the line if there are no replies #7

Open westlinkin opened 2 years ago

westlinkin commented 2 years ago

Great library!

But if the root comment has no replies, the lib will draw the line to the next root comment. But if there are replies, the line end with the last reply, won't draw to the next root comment.

I think if there are no replies, it shouldn't draw the line at all.

Thanks.

bugrevealingbme commented 2 years ago

agree

immi420 commented 2 years ago

Did you find any solution to this issue?

westlinkin commented 2 years ago

Did you find any solution to this issue?

I updated the root_comment_widget myself, passed in a boolean value called hasReplies, if it is true, do not draw anything inside paint function of RootPainter.

This project seems out of maintaining, so I didn't bother submitting the PR.

immi420 commented 2 years ago

i did a similar thing and replaced the line color to Transparent when there's no replies and that worked

raduungurean commented 1 year ago 
        treeThemeData: TreeThemeData(
          lineColor: Colors.green[500]!,
          lineWidth: comment.replies!.isEmpty ? 0 : 3,
        ),
pishguy commented 1 year ago

@westlinkin @raduungurean

hi, do you know how can we connect root avatars together? like with another timelines