dangnvbkit / sparserss

Automatically exported from code.google.com/p/sparserss
Other
0 stars 0 forks source link

Custom ringtones for each feed (patch included) #58

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Here's an (unfinished) patch which allows to set a custom feed ringtone for 
each feed when right clicking it at "Additional settings".

If global menu notification is enabled, the user can select to override the 
global menu ringtone for each feed by activating the checkbox. The notification 
sound then will be the one selected for the user if this feed has new updates.

If multiple feeds have updates, then the first non silent custom sound will be 
played, eg:

Feed A: has updates, global sound overridden to silence
Feed B: has no updates, global sound overridden to something non silent
Feed C: has updates, global sound overridden to something non silent
Feed D: has updates, global sound not overridden

In this case the sound set for feed C will be triggered. The positioning of the 
feeds is important for this.

If in the above example feed C has overridden global sound to silence, the 
global sound would be triggered for this update because of feed D.

One thing not working: The custom ringtone is not restored to the 
RingtonePreference yet. Don't know how to do this, yet.

The patch needs some testing and polishing, too. Feel free to add your comments 
for a first review and if this can make it in some next release.

Original issue reported on code.google.com by markus.d...@gmail.com on 19 May 2011 at 3:35

Attachments:

GoogleCodeExporter commented 9 years ago
Here's a second version. Polished the strings a little bit and added option to 
disable alerts for a feed globally. No icon and no ringtone will be played if 
selected. Supersedes the patch above.

Original comment by markus.d...@gmail.com on 19 May 2011 at 7:47

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch. 

I am not completely sure whether to add this, or not, because this extends the 
"simple" attribute somehow.

Let me think about this.

Original comment by handschuh.stefan on 19 May 2011 at 8:01

GoogleCodeExporter commented 9 years ago
I admit it adds some load, but for me these are essential features if I want to 
have more than one feed. And sparserss does nothing more than it did before. 
Just some global settings are configurable on a per feed basis. But they don't 
have to. So no hassle for users don't willing to touch anything of this (maybe 
they won't even notice).

So it is still "simple", but also a little bit more configurable for users that 
want it (like me :-)).

Original comment by markus.d...@gmail.com on 19 May 2011 at 10:27

GoogleCodeExporter commented 9 years ago
Sorry, this does not fit the description "simple rss reader", I think.

Original comment by handschuh.stefan on 23 May 2011 at 9:38