dangoslen / constable-github-action

An action for seeing how contributable a repository is.
MIT License
0 stars 24 forks source link

Issue 10 #35

Closed yash01234 closed 3 years ago

yash01234 commented 3 years ago

Updating the markdown table with latest variable names

dangoslen commented 3 years ago

I think the changes look good, but the black box test isn't running - https://github.com/dangoslen/constable-github-action/pull/35/checks?check_run_id=1130752918

Not sure, but it looks like something is happening when trying to generate the table

yash01234 commented 3 years ago

how do we go about fixing this?

tirthpatel7498 commented 3 years ago

@yash01234 Run npm run package command after you update the index.js file. That will make changes to the dist/index.js file as well coz there's a difference in those 2 files.

tirthpatel7498 commented 3 years ago

Also, can you take index.js again from main branch and copy your code for the table in that. I think you are using the old index.js file. May be the checks are not passing because of that.

dangoslen commented 3 years ago

@yash01234 you need to update the dist/index.js file using the npm run package command. Once you do that, just commit and push those changes and it should be good.

yash01234 commented 3 years ago

When I run (npm run package) command I get an error. I go onto check the logs and I see- (error missing script: markdown-table) as an error for some reason

dangoslen commented 3 years ago

interesting. sounds like you have an odd environment that isn't including everything in your node modules directory.

have you done npm install since the markdown-table was added to the package.json?

yash01234 commented 3 years ago

Yes works now. Thanks :)

dangoslen commented 3 years ago

awesome! feel free to merge

yash01234 commented 3 years ago

Done