dangowrt / owrt-ubi-installer

OpenWrt firmware installer for the Linksys E8450 aka. Belkin RT3200
GNU General Public License v2.0
393 stars 50 forks source link

Update Containerfile #119

Closed jauderho closed 1 year ago

jauderho commented 1 year ago

Using bullseye-slim instead of bullseye saves about 100MB in the resulting image. Not huge but every little bit helps.

REPOSITORY                        TAG             IMAGE ID       CREATED          SIZE
owrt                              latest          e63400b3f114   14 seconds ago   1.11GB
owrt-slim                         latest          6fae00390136   9 minutes ago    1.01GB
jauderho commented 1 year ago

Actually, should the image be ubuntu instead given that the actual workflow currently uses ubuntu-latest? Using ubuntu results in an image about the same size as bullseye-slim.

REPOSITORY                        TAG             IMAGE ID       CREATED          SIZE
owrt-ubuntu                       latest          aaf239b4988a   2 minutes ago    1.02GB
owrt                              latest          e63400b3f114   13 minutes ago   1.11GB
owrt-slim                         latest          6fae00390136   22 minutes ago   1.01GB
dangowrt commented 1 year ago

I'd rather have the workflow changed to also run on debian/bullseye-slim...

jauderho commented 1 year ago

AFAIK, GitHub Actions only run on Ubuntu, macOS and Windows.

https://github.com/actions/runner-images

dangowrt commented 1 year ago

AFAIK, GitHub Actions only run on Ubuntu, macOS and Windows. That's sad. But ok, I'm not complaining about having CI resources thrown at me for free.

Let's use Ubuntu for the Containerfile as well then, like you suggested.

jauderho commented 1 year ago

I've updated the PR and also changed the workflow to use ubuntu-22.04 instead of ubuntu-latest to match.