search

dangowrt / owrt-ubi-installer

OpenWrt firmware installer for the Linksys E8450 aka. Belkin RT3200
GNU General Public License v2.0
393 stars 50 forks source link

Configure additional package via CI #88

Closed gzzsound closed 2 years ago

gzzsound commented 2 years ago

Hello! first of all, thanks for the work on this project!

I recently forked the repo and try to compile the firmware with some additional packages. After some yak shaving configuring the environment (I am on MacOs) I decided to leverage the pipeline on GH actions to create the custom firmware :)

To make it work I simply changed the build_installer.sh with the additional packages and triggered the build.

Thinking about how I could make it slightly better for my needs, I then added a parameter to the GH action so that the packages can be configured when running the pipeline (this PR). Do you think this could be something useful for other people too? looking at the forks, it seems that people fork 'just' to add additional packages.

If you think this makes sense to have on master, I could add some bits of docs.

Thanks again!

dangowrt commented 2 years ago

Thank you for contributing and teaching me a bit on how to use Github actions (something still very new to me) :wink:

However, I never quite understood why users would use this repository to generate sysupgrade images. This repository was needed as neither the OpenWrt ImageBuilder nor the OpenWrt buildroot would allow to generate the installer image (an initramfs containing yet another initramfs among with a script and other things to be written to flash -- it's that matryoshka-like nature which is impossible to implement in the current build system without major changes). To make it more clear: It's only the installer part which is not yet officially supported by OpenWrt, all the rest is (ie. this is not a community build or anything like that).

Hence users may just use Chef to generate custom images, just like for any other officially supported device, all without editing code or even having a Github account. chef

With the upcoming release and now that there is an official pre-release snapshot image I was planning to actually remove the generation of the custom sysupgrade image from this script as that was basically just a work-around to let "normal users" try OpenWrt (with LuCI and everything they would expect from a release version) on this device.

gzzsound commented 2 years ago

Thanks @dangowrt for taking the time for such a detailed reply :)

Wrongly, I was under the impression that this was the only way to get the image for the router. Now I understand why the repo has been renamed too :)

Closing the PR and the issue!